Re: [PATCH] t5300-pack-object.sh: portability issue using /usr/bin/stat
- From
Nicolas Pitre <nico@cam.org>
- Date
- Apr 7, 2007, 02:33 UTC
- Message-ID
- <alpine.LFD.0.98.0704062227430.28181@xanadu.home>
- In-Reply-To
- <7vfy7dgcn1.fsf@assigned-by-dhcp.cox.net>
On Fri, 6 Apr 2007, Junio C Hamano wrote:
Show 10 quoted lines
> arjen@yaph.org (Arjen Laarhoven) writes: > > > In the test 'compare delta flavors', /usr/bin/stat is used to get file size. > > This isn't portable. There already is a dependency on Perl, use its '-s' > > operator to get the file size. > > If you do use Perl, then you do not want to do it as two > separate invocations with their result compared with test. > > How about this on top of your patch?
Well... since this test already depends on wc then why not just use that instead of adding a perl dependency?
Something like:
diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh index 35e036a..ba785cf 100755 --- a/t/t5300-pack-object.sh +++ b/t/t5300-pack-object.sh @@ -125,8 +125,8 @@ cd "$TRASH" test_expect_success \ 'compare delta flavors' \ - 'size_2=`stat -c "%s" test-2-${packname_2}.pack` && - size_3=`stat -c "%s" test-3-${packname_3}.pack` && + 'size_2=`wc -c < test-2-${packname_2}.pack` && + size_3=`wc -c < test-3-${packname_3}.pack` && test $size_2 -gt $size_3' rm -fr .git2