Re: [PATCH] t5300-pack-object.sh: portability issue using /usr/bin/stat

From

Junio C Hamano <junkio@cox.net>

Date

Apr 7, 2007, 02:08 UTC

Message-ID

<7vfy7dgcn1.fsf@assigned-by-dhcp.cox.net>

In-Reply-To

<20070406234903.GJ3854@regex.yaph.org>

arjen@yaph.org (Arjen Laarhoven) writes:

> In the test 'compare delta flavors', /usr/bin/stat is used to get file size.
> This isn't portable.  There already is a dependency on Perl, use its '-s'
> operator to get the file size.

How about this on top of your patch?

diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh
index a400e7a..5710a23 100755
--- a/t/t5300-pack-object.sh
+++ b/t/t5300-pack-object.sh
@@ -123,11 +123,13 @@ test_expect_success \
      done'
 cd "$TRASH"
 
-test_expect_success \
-    'compare delta flavors' \
-    'size_2=`perl -e "print -s q[test-2-${packname_2}.pack]"` &&
-     size_3=`perl -e "print -s q[test-3-${packname_3}.pack]"` &&
-     test $size_2 -gt $size_3'
+test_expect_success 'compare delta flavors' '
+	perl -e "
+		exit ( ((-s q[test-2-${packname_2}.pack]) >
+			(-s q[test-3-${packname_3}.pack]))
+			? 0 : 1);
+	"
+'
 
 rm -fr .git2
 mkdir .git2