Re: [PATCH v2 2/2] Windows: stop supplying BLK_SHA1=YesPlease by default

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 4, 2018, 17:33 UTC
Message-ID: <alpine.DEB.2.21.1.1801041828540.31@MININT-6BKU6QN.europe.corp.microsoft.com>
In-Reply-To: <20171228140742.26735-3-avarab@gmail.com>

Hi,

On Thu, 28 Dec 2017, Ævar Arnfjörð Bjarmason wrote:

Show 30 quoted lines

> Using BLK_SHA1 in lieu of the OpenSSL routines was done in
> 9bccfcdbff ("Windows: use BLK_SHA1 again", 2009-10-22), since DC_SHA1
> is now the default for git in general it makes sense for Windows to
> use that too, this looks like something that was missed back in
> e6b07da278 ("Makefile: make DC_SHA1 the default", 2017-03-17).
> 
> As noted in 2cfc70f0de ("mingw: use OpenSSL's SHA-1 routines",
> 2017-02-09) OpenSSL has a performance benefit compared to BLK_SHA1 on
> MinGW, so perhaps that and the Windows default should be changed
> around again. That's a topic for another series, it seems clear that
> this specific flag is nobody's explicit intention.
> 
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  config.mak.uname | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/config.mak.uname b/config.mak.uname
> index 685a80d138..6a862abd35 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -361,7 +361,6 @@ ifeq ($(uname_S),Windows)
>  	NO_REGEX = YesPlease
>  	NO_GETTEXT = YesPlease
>  	NO_PYTHON = YesPlease
> -	BLK_SHA1 = YesPlease
>  	ETAGS_TARGET = ETAGS
>  	NO_INET_PTON = YesPlease
>  	NO_INET_NTOP = YesPlease

This patch is actually identical to 8756c75cd10 (msvc: use OpenSSL's SHA-1 routines, 2016-10-12) in Git for Windows' master.

I did plan to submit this, but it is part of a bigger effort to get Git to build in current versions of Visual Studio again.

Before this work, the MSVC build could only use an ancient OpenSSL version from pre-built binaries hosted on repo.or.cz, and those are unlikely to get the performance benefits that you seek.

So I would like to ask to skip this patch for now, and take Jeff Hostetler's patch as part of the MSVC patches later, once they have been matured in Git for Windows?

Thanks, Dscho