Re: [PATCH v2 2/2] Windows: stop supplying BLK_SHA1=YesPlease by default

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Dec 28, 2017, 19:04 UTC
Message-ID: <20171228190452.GB92530@aiede.mtv.corp.google.com>
In-Reply-To: <20171228140742.26735-3-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

Show 5 quoted lines

> Using BLK_SHA1 in lieu of the OpenSSL routines was done in
> 9bccfcdbff ("Windows: use BLK_SHA1 again", 2009-10-22), since DC_SHA1
> is now the default for git in general it makes sense for Windows to
> use that too, this looks like something that was missed back in
> e6b07da278 ("Makefile: make DC_SHA1 the default", 2017-03-17).

micronit: the commas should be periods.

With or without such a tweak, this is indeed
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.