git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] Windows: stop supplying BLK_SHA1=YesPlease by default

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Dec 27, 2017, 23:00 UTC
Message-ID
<20171227230038.14386-3-avarab@gmail.com>
In-Reply-To
<20171227230038.14386-1-avarab@gmail.com>

Using BLK_SHA1 in lieu of the OpenSSL routines was done in [1], but since DC_SHA1 is now the default for git in general it makes sense for Windows to use that too, this looks like something that was missed back in [2].

As noted in [3] OpenSSL has a performance benefit compared to BLK_SHA1 on MinGW, so perhaps that and the Windows default should be changed around again, but that's a topic for another series, it seems clear that this specific flag is nobody's explicit intention.

1. 9bccfcdbff ("Windows: use BLK_SHA1 again", 2009-10-22)
2. e6b07da278 ("Makefile: make DC_SHA1 the default", 2017-03-17)
3. 2cfc70f0de ("mingw: use OpenSSL's SHA-1 routines", 2017-02-09)
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 config.mak.uname | 1 -
 1 file changed, 1 deletion(-)
diff --git a/config.mak.uname b/config.mak.uname
index 685a80d138..6a862abd35 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -361,7 +361,6 @@ ifeq ($(uname_S),Windows)
 	NO_REGEX = YesPlease
 	NO_GETTEXT = YesPlease
 	NO_PYTHON = YesPlease
-	BLK_SHA1 = YesPlease
 	ETAGS_TARGET = ETAGS
 	NO_INET_PTON = YesPlease
 	NO_INET_NTOP = YesPlease
-- 
2.15.1.424.g9478a66081
Previous: Ævar Arnfjörð BjarmasonNext: Jonathan Nieder
Message 2 of 15 in “When DC_SHA1 was made the default we missed a spot”
  1. 0/2 When DC_SHA1 was made the default we missed a spotÆvar Arnfjörð Bjarmason, Dec 27, 2017
  2. 2/2 Windows: stop supplying BLK_SHA1=YesPlease by defaultÆvar Arnfjörð Bjarmason, Dec 27, 2017
  3. Jonathan NiederDec 27, 2017
  4. Ævar Arnfjörð BjarmasonDec 28, 2017
  5. Johannes SchindelinJan 4, 2018
  6. 1/2 Makefile: NO_OPENSSL=1 should no longer imply BLK_SHA1=1Ævar Arnfjörð Bjarmason, Dec 27, 2017
  7. Jonathan NiederDec 27, 2017
  8. 0/2 When DC_SHA1 was made the default we missed a spotÆvar Arnfjörð Bjarmason, Dec 28, 2017
  9. 1/2 Makefile: NO_OPENSSL=1 should no longer imply BLK_SHA1=1Ævar Arnfjörð Bjarmason, Dec 28, 2017
  10. Jonathan NiederDec 28, 2017
  11. 2/2 Windows: stop supplying BLK_SHA1=YesPlease by defaultÆvar Arnfjörð Bjarmason, Dec 28, 2017
  12. Jonathan NiederDec 28, 2017
  13. Johannes SchindelinJan 4, 2018
  14. Ævar Arnfjörð BjarmasonJan 4, 2018
  15. Junio C HamanoJan 5, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.