Re: [PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 27, 2017, 21:24 UTC
Message-ID: <alpine.DEB.2.21.1.1711272222100.6482@virtualbox>
In-Reply-To: <CALNjmMo3KH4QXY00ViVaiHdy=pSZ5j0BWRueO1T=sC_r0=3c3g@mail.gmail.com>

Hi,

On Mon, 27 Nov 2017, Takuto Ikuta wrote:

Show 26 quoted lines

> 2017-11-27 13:53 GMT+09:00 Junio C Hamano <gitster@pobox.com>:
> > Jeff King <peff@peff.net> writes:
> >
> >>> The 5-patch series that contains the same change as this one is
> >>> cooking and will hopefully be in the released version before the end
> >>> of the year.
> >>
> >> I'd be curious if the 5th patch there provides an additional speedup
> >> for Takuto's case.
> >
> > Indeed, it is a very good point.
> >
> > IIUC, the 5th one is about fetching tons of refs that you have never
> > seen, right?  If a repository that has trouble with everything-local
> > is suffering because it right now has 300k remote-tracking branches,
> > I'd imagine that these remote-tracking branches are being added at a
> > considerable rate, so I'd not be surprised if these "new" refs
> > benefits from that patch.  And it would be nice to know how much a
> > real life scenario actually does improve.
> >
> > Thanks.
> 
> In chromium repository,  your 5th patch does not improve performance,
> took more than 5 minutes to run fetch on windows.
> 4th patch is very important for the repository in daily fetch.
> I hope your 4th patch will be merged.

If you want it in Git for Windows early (where performance is traditionally worse than on Linux because Git is really optimized for Linux), I would not mind a Pull Request at https://github.com/git-for-windows/git.

My current plan is to release a new Git for Windows version on Wednesday, to allow for a new cURL version to be bundled.

Ciao, Johannes