Re: [PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack

From: Takuto Ikuta <tikuta@google.com>
Date: Nov 27, 2017, 05:01 UTC
Message-ID: <CALNjmMo3KH4QXY00ViVaiHdy=pSZ5j0BWRueO1T=sC_r0=3c3g@mail.gmail.com>
In-Reply-To: <xmqqk1yce301.fsf@gitster.mtv.corp.google.com>

2017-11-27 13:53 GMT+09:00 Junio C Hamano <gitster@pobox.com>:

Show 7 quoted lines

> Jeff King <peff@peff.net> writes:
>
>>> cf. https://public-inbox.org/git/20171120202920.7ppcwmzkxifywtoj@sigill.intra.peff.net/
>>
>> It's funny that we'd get two patches so close together. AFAIK the
>> slowness here has been with us for years, and I just happened to
>> investigate it recently.

Yes, thank you for let me know. Please ignore my patch, sorry.

Show 19 quoted lines

>>
>>> The 5-patch series that contains the same change as this one is
>>> cooking and will hopefully be in the released version before the end
>>> of the year.
>>
>> I'd be curious if the 5th patch there provides an additional speedup for
>> Takuto's case.
>
> Indeed, it is a very good point.
>
> IIUC, the 5th one is about fetching tons of refs that you have never
> seen, right?  If a repository that has trouble with everything-local
> is suffering because it right now has 300k remote-tracking branches,
> I'd imagine that these remote-tracking branches are being added at a
> considerable rate, so I'd not be surprised if these "new" refs
> benefits from that patch.  And it would be nice to know how much a
> real life scenario actually does improve.
>
> Thanks.

In chromium repository, your 5th patch does not improve performance, took more than 5 minutes to run fetch on windows. 4th patch is very important for the repository in daily fetch. I hope your 4th patch will be merged.

Thanks.

-- 
Takuto Ikuta
Software Engineer in Tokyo
Chrome Infrastructure (goma team)