Re: [PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack
- From
Jeff King <peff@peff.net>
- Date
- Nov 27, 2017, 04:37 UTC
- Message-ID
- <20171127043740.GA5994@sigill>
- In-Reply-To
- <xmqqo9noe3u0.fsf@gitster.mtv.corp.google.com>
On Mon, Nov 27, 2017 at 01:35:35PM +0900, Junio C Hamano wrote:
Show 18 quoted lines
> Takuto Ikuta <tikuta@google.com> writes:
>
> > diff --git a/fetch-pack.c b/fetch-pack.c
> > index 008b25d3db087..0184584e80599 100644
> > --- a/fetch-pack.c
> > +++ b/fetch-pack.c
> > @@ -716,7 +716,7 @@ static int everything_local(struct fetch_pack_args *args,
> > for (ref = *refs; ref; ref = ref->next) {
> > struct object *o;
> >
> > - if (!has_object_file(&ref->old_oid))
> > + if (!has_object_file_with_flags(&ref->old_oid, OBJECT_INFO_QUICK))
> > continue;
> >
>
> It appears that great minds think alike?
>
> cf. https://public-inbox.org/git/20171120202920.7ppcwmzkxifywtoj@sigill.intra.peff.net/It's funny that we'd get two patches so close together. AFAIK the slowness here has been with us for years, and I just happened to investigate it recently.
> The 5-patch series that contains the same change as this one is > cooking and will hopefully be in the released version before the end > of the year.
I'd be curious if the 5th patch there provides an additional speedup for Takuto's case.
-Peff