git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 03/31] config: don't implicitly use gitdir

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jun 8, 2017, 10:41 UTC
Message-ID
<alpine.DEB.2.21.1.1706081235130.171564@virtualbox>
In-Reply-To
<20170531214417.38857-4-bmwill@google.com>
Hi Brandon,
On Wed, 31 May 2017, Brandon Williams wrote:
Show 6 quoted lines
> Commit 2185fde56 (config: handle conditional include when $GIT_DIR is
> not set up) added a 'git_dir' field to the config_options struct.  Let's
> use this option field explicitly all the time instead of occasionally
> falling back to calling 'git_pathdup("config")' to get the path to the
> local repository configuration.  This allows 'go_git_config_sequence()'
> to not implicitly rely on global repository state.
Oh wow. `git_pathdup()`...

Sadly, I lack the time to review the entire patch series, but this here change definitely looks correct to me.

Thanks, Dscho

Previous: Brandon WilliamsNext: Brandon Williams
Message 12 of 196 in “repository object”
  1. 00/31 repository objectBrandon Williams, May 31, 2017
  2. 01/31 config: create config.hBrandon Williams, May 31, 2017
  3. 02/31 config: don't include config.h by defaultBrandon Williams, May 31, 2017
  4. 05/31 environment: remove namespace_len variableBrandon Williams, May 31, 2017
  5. Stefan BellerJun 1, 2017
  6. Brandon WilliamsJun 1, 2017
  7. 06/31 repo: introduce the repository objectBrandon Williams, May 31, 2017
  8. Stefan BellerJun 1, 2017
  9. Brandon WilliamsJun 5, 2017
  10. Stefan BellerJun 5, 2017
  11. 03/31 config: don't implicitly use gitdirBrandon Williams, May 31, 2017
  12. Johannes SchindelinJun 8, 2017
  13. Brandon WilliamsJun 8, 2017
  14. Johannes SchindelinJun 8, 2017
  15. Brandon WilliamsJun 8, 2017
  16. 08/31 environment: store worktree in the_repositoryBrandon Williams, May 31, 2017
  17. 13/31 repo: add repo_read_gitmodulesBrandon Williams, May 31, 2017
  18. 11/31 repo: add index_state to struct repoBrandon Williams, May 31, 2017
  19. 07/31 environment: place key repository state in the_repositoryBrandon Williams, May 31, 2017
  20. 12/31 submodule-config: store the_submodule_cache in the_repositoryBrandon Williams, May 31, 2017
  21. 14/31 submodule: convert is_submodule_initialized to work on a repositoryBrandon Williams, May 31, 2017
  22. 16/31 convert: convert crlf_to_git to take an indexBrandon Williams, May 31, 2017
  23. 15/31 convert: convert get_cached_convert_stats_ascii to take an indexBrandon Williams, May 31, 2017
  24. 19/31 convert: convert renormalize_buffer to take an indexBrandon Williams, May 31, 2017
  25. 22/31 ls-files: convert write_eolinfo to take an indexBrandon Williams, May 31, 2017
  26. 21/31 ls-files: convert overlay_tree_on_cache to take an indexBrandon Williams, May 31, 2017
  27. 20/31 tree: convert read_tree to take an index parameterBrandon Williams, May 31, 2017
  28. 18/31 convert: convert convert_to_git to take an indexBrandon Williams, May 31, 2017
  29. 28/31 ls-files: convert show_files to take an indexBrandon Williams, May 31, 2017
  30. 25/31 ls-files: convert show_ru_info to take an indexBrandon Williams, May 31, 2017
  31. 24/31 ls-files: convert show_other_files to take an indexBrandon Williams, May 31, 2017
  32. 30/31 ls-files: factor out tag calculationBrandon Williams, May 31, 2017
  33. 29/31 ls-files: factor out debug info into a functionBrandon Williams, May 31, 2017
  34. 31/31 ls-files: use repository objectBrandon Williams, May 31, 2017
  35. Stefan BellerJun 1, 2017
  36. Brandon WilliamsJun 5, 2017
  37. 23/31 ls-files: convert show_killed_files to take an indexBrandon Williams, May 31, 2017
  38. 27/31 ls-files: convert prune_cache to take an indexBrandon Williams, May 31, 2017
  39. 26/31 ls-files: convert ce_excluded to take an indexBrandon Williams, May 31, 2017
  40. 17/31 convert: convert convert_to_git_filter_fd to take an indexBrandon Williams, May 31, 2017
  41. 10/31 config: migrate the_configset to the_repositoryBrandon Williams, May 31, 2017
  42. 04/31 setup: don't perform lazy initialization of repository stateBrandon Williams, May 31, 2017
  43. Stefan BellerJun 1, 2017
  44. Jeff KingJun 2, 2017
  45. Brandon WilliamsJun 5, 2017
  46. Jeff KingJun 5, 2017
  47. Brandon WilliamsJun 5, 2017
  48. 09/31 setup: add comment indicating a hackBrandon Williams, May 31, 2017
  49. Stefan BellerMay 31, 2017
  50. Brandon WilliamsMay 31, 2017
  51. Brandon WilliamsJun 1, 2017
  52. Stefan BellerJun 1, 2017
  53. Jacob KellerJun 1, 2017
  54. 00/32 repository objectBrandon Williams, Jun 8, 2017
  55. 01/32 config: create config.hBrandon Williams, Jun 8, 2017
  56. 02/32 config: remove git_config_iterBrandon Williams, Jun 8, 2017
  57. 04/32 config: don't implicitly use gitdirBrandon Williams, Jun 8, 2017
  58. Brandon WilliamsJun 12, 2017
  59. 03/32 config: don't include config.h by defaultBrandon Williams, Jun 8, 2017
  60. 05/32 setup: don't perform lazy initialization of repository stateBrandon Williams, Jun 8, 2017
  61. 07/32 repository: introduce the repository objectBrandon Williams, Jun 8, 2017
  62. 0/2 Add a freez() wrapperÆvar Arnfjörð Bjarmason, Jun 9, 2017
  63. 1/2 git-compat-util: add a freez() wrapper around free(x); x = NULLÆvar Arnfjörð Bjarmason, Jun 9, 2017
  64. Christian CouderJun 9, 2017
  65. 2/2 *.[ch] refactoring: make use of the freez() wrapperÆvar Arnfjörð Bjarmason, Jun 9, 2017
  66. Martin ÅgrenJun 9, 2017
  67. Ævar Arnfjörð BjarmasonJun 9, 2017
  68. Brandon WilliamsJun 9, 2017
  69. Brandon WilliamsJun 9, 2017
  70. 0/2 Add a FREEZ() wrapper macroÆvar Arnfjörð Bjarmason, Jun 9, 2017
  71. 1/2 git-compat-util: add a FREEZ() wrapper around free(ptr); ptr = NULLÆvar Arnfjörð Bjarmason, Jun 9, 2017
  72. Jonathan NiederJun 9, 2017
  73. Eric WongJun 9, 2017
  74. Junio C HamanoJun 10, 2017
  75. Eric WongJun 10, 2017
  76. Jeff KingJun 10, 2017
  77. Junio C HamanoJun 15, 2017
  78. Ævar Arnfjörð BjarmasonJun 15, 2017
  79. 0/2 Add a FREE_AND_NULL() wrapper macroÆvar Arnfjörð Bjarmason, Jun 15, 2017
  80. 1/2 git-compat-util: add a FREE_AND_NULL() wrapper around free(ptr); ptr = NULLÆvar Arnfjörð Bjarmason, Jun 15, 2017
  81. 2/2 *.[ch] refactoring: make use of the FREE_AND_NULL() macroÆvar Arnfjörð Bjarmason, Jun 15, 2017
  82. Junio C HamanoJun 15, 2017
  83. Andreas SchwabJun 10, 2017
  84. 2/2 *.[ch] refactoring: make use of the FREEZ() macroÆvar Arnfjörð Bjarmason, Jun 9, 2017
  85. 10/32 setup: add comment indicating a hackBrandon Williams, Jun 8, 2017
  86. 06/32 environment: remove namespace_len variableBrandon Williams, Jun 8, 2017
  87. 09/32 environment: store worktree in the_repositoryBrandon Williams, Jun 8, 2017
  88. 16/32 convert: convert get_cached_convert_stats_ascii to take an indexBrandon Williams, Jun 8, 2017
  89. 14/32 submodule: add repo_read_gitmodulesBrandon Williams, Jun 8, 2017
  90. 19/32 convert: convert convert_to_git to take an indexBrandon Williams, Jun 8, 2017
  91. 22/32 ls-files: convert overlay_tree_on_cache to take an indexBrandon Williams, Jun 8, 2017
  92. 23/32 ls-files: convert write_eolinfo to take an indexBrandon Williams, Jun 8, 2017
  93. 20/32 convert: convert renormalize_buffer to take an indexBrandon Williams, Jun 8, 2017
  94. 15/32 submodule: convert is_submodule_initialized to work on a repositoryBrandon Williams, Jun 8, 2017
  95. 25/32 ls-files: convert show_other_files to take an indexBrandon Williams, Jun 8, 2017
  96. 21/32 tree: convert read_tree to take an index parameterBrandon Williams, Jun 8, 2017
  97. 30/32 ls-files: factor out debug info into a functionBrandon Williams, Jun 8, 2017
  98. 27/32 ls-files: convert ce_excluded to take an indexBrandon Williams, Jun 8, 2017
  99. 32/32 ls-files: use repository objectBrandon Williams, Jun 8, 2017
  100. Brandon WilliamsJun 9, 2017
  101. Junio C HamanoJun 10, 2017
  102. Brandon WilliamsJun 12, 2017
  103. 29/32 ls-files: convert show_files to take an indexBrandon Williams, Jun 8, 2017
  104. 24/32 ls-files: convert show_killed_files to take an indexBrandon Williams, Jun 8, 2017
  105. 26/32 ls-files: convert show_ru_info to take an indexBrandon Williams, Jun 8, 2017
  106. 28/32 ls-files: convert prune_cache to take an indexBrandon Williams, Jun 8, 2017
  107. 17/32 convert: convert crlf_to_git to take an indexBrandon Williams, Jun 8, 2017
  108. 31/32 ls-files: factor out tag calculationBrandon Williams, Jun 8, 2017
  109. 18/32 convert: convert convert_to_git_filter_fd to take an indexBrandon Williams, Jun 8, 2017
  110. 13/32 submodule-config: store the_submodule_cache in the_repositoryBrandon Williams, Jun 8, 2017
  111. 12/32 repository: add index_state to struct repoBrandon Williams, Jun 8, 2017
  112. 08/32 environment: place key repository state in the_repositoryBrandon Williams, Jun 8, 2017
  113. 11/32 config: read config from a repository objectBrandon Williams, Jun 8, 2017
  114. Jonathan TanJun 10, 2017
  115. Jeff KingJun 10, 2017
  116. Jeff KingJun 10, 2017
  117. Brandon WilliamsJun 11, 2017
  118. Jonathan TanJun 12, 2017
  119. Brandon WilliamsJun 11, 2017
  120. Stefan BellerJun 12, 2017
  121. Jeff KingJun 12, 2017
  122. Jonathan TanJun 12, 2017
  123. Brandon WilliamsJun 12, 2017
  124. Jonathan TanJun 12, 2017
  125. Jeff KingJun 12, 2017
  126. 00/20 repository objectBrandon Williams, Jun 20, 2017
  127. 04/20 repository: introduce the repository objectBrandon Williams, Jun 20, 2017
  128. Stefan BellerJun 20, 2017
  129. Brandon WilliamsJun 21, 2017
  130. Stefan BellerJun 21, 2017
  131. Jonathan TanJun 20, 2017
  132. Brandon WilliamsJun 20, 2017
  133. 15/20 repository: add index_state to struct repoBrandon Williams, Jun 20, 2017
  134. Jonathan TanJun 21, 2017
  135. Brandon WilliamsJun 21, 2017
  136. Stefan BellerJun 21, 2017
  137. 02/20 setup: add comment indicating a hackBrandon Williams, Jun 20, 2017
  138. 08/20 path: always pass in commondir to update_common_dirBrandon Williams, Jun 20, 2017
  139. 14/20 config: read config from a repository objectBrandon Williams, Jun 20, 2017
  140. 20/20 ls-files: use repository objectBrandon Williams, Jun 20, 2017
  141. Jonathan TanJun 21, 2017
  142. 16/20 submodule-config: store the_submodule_cache in the_repositoryBrandon Williams, Jun 20, 2017
  143. 18/20 submodule: convert is_submodule_initialized to work on a repositoryBrandon Williams, Jun 20, 2017
  144. 19/20 repository: enable initialization of submodulesBrandon Williams, Jun 20, 2017
  145. Jonathan TanJun 21, 2017
  146. Brandon WilliamsJun 21, 2017
  147. 17/20 submodule: add repo_read_gitmodulesBrandon Williams, Jun 20, 2017
  148. 07/20 path: create path.hBrandon Williams, Jun 20, 2017
  149. 12/20 path: add repo_git_path and strbuf_repo_git_pathBrandon Williams, Jun 20, 2017
  150. 05/20 environment: place key repository state in the_repositoryBrandon Williams, Jun 20, 2017
  151. Jonathan TanJun 20, 2017
  152. 10/20 path: convert do_git_path to take a 'struct repository'Brandon Williams, Jun 20, 2017
  153. Jonathan TanJun 20, 2017
  154. Brandon WilliamsJun 21, 2017
  155. 11/20 path: construct correct path to a worktree's indexBrandon Williams, Jun 20, 2017
  156. Stefan BellerJun 20, 2017
  157. Jonathan NiederJun 20, 2017
  158. Brandon WilliamsJun 21, 2017
  159. Jonathan NiederJun 21, 2017
  160. Jonathan NiederJun 21, 2017
  161. Brandon WilliamsJun 21, 2017
  162. Jonathan NiederJun 21, 2017
  163. Junio C HamanoJun 21, 2017
  164. 06/20 environment: store worktree in the_repositoryBrandon Williams, Jun 20, 2017
  165. 03/20 environment: remove namespace_len variableBrandon Williams, Jun 20, 2017
  166. 01/20 setup: don't perform lazy initialization of repository stateBrandon Williams, Jun 20, 2017
  167. 13/20 path: add repo_worktree_path and strbuf_repo_worktree_pathBrandon Williams, Jun 20, 2017
  168. 09/20 path: convert strbuf_git_common_path to take a 'struct repository'Brandon Williams, Jun 20, 2017
  169. Stefan BellerJun 20, 2017
  170. 00/20 repository objectBrandon Williams, Jun 22, 2017
  171. 01/20 setup: don't perform lazy initialization of repository stateBrandon Williams, Jun 22, 2017
  172. 02/20 setup: add comment indicating a hackBrandon Williams, Jun 22, 2017
  173. 04/20 repository: introduce the repository objectBrandon Williams, Jun 22, 2017
  174. 05/20 environment: place key repository state in the_repositoryBrandon Williams, Jun 22, 2017
  175. 03/20 environment: remove namespace_len variableBrandon Williams, Jun 22, 2017
  176. 09/20 path: convert strbuf_git_common_path to take a 'struct repository'Brandon Williams, Jun 22, 2017
  177. 08/20 path: always pass in commondir to update_common_dirBrandon Williams, Jun 22, 2017
  178. 07/20 path: create path.hBrandon Williams, Jun 22, 2017
  179. 06/20 environment: store worktree in the_repositoryBrandon Williams, Jun 22, 2017
  180. 11/20 path: worktree_git_path() should not use file relocationBrandon Williams, Jun 22, 2017
  181. 16/20 submodule-config: store the_submodule_cache in the_repositoryBrandon Williams, Jun 22, 2017
  182. 10/20 path: convert do_git_path to take a 'struct repository'Brandon Williams, Jun 22, 2017
  183. 18/20 submodule: convert is_submodule_initialized to work on a repositoryBrandon Williams, Jun 22, 2017
  184. 14/20 config: read config from a repository objectBrandon Williams, Jun 22, 2017
  185. 19/20 repository: enable initialization of submodulesBrandon Williams, Jun 22, 2017
  186. 17/20 submodule: add repo_read_gitmodulesBrandon Williams, Jun 22, 2017
  187. 20/20 ls-files: use repository objectBrandon Williams, Jun 22, 2017
  188. 13/20 path: add repo_worktree_path and strbuf_repo_worktree_pathBrandon Williams, Jun 22, 2017
  189. 12/20 path: add repo_git_path and strbuf_repo_git_pathBrandon Williams, Jun 22, 2017
  190. 15/20 repository: add index_state to struct repoBrandon Williams, Jun 22, 2017
  191. Junio C HamanoJun 22, 2017
  192. Brandon WilliamsJun 22, 2017
  193. Junio C HamanoJun 22, 2017
  194. Stefan BellerJun 22, 2017
  195. Jeff HostetlerJun 23, 2017
  196. Junio C HamanoJun 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.