[PATCH v3 02/20] setup: add comment indicating a hack
- From
- Brandon Williams <bmwill@google.com>
- Date
- Jun 20, 2017, 19:19 UTC
- Message-ID
- <20170620191951.84791-3-bmwill@google.com>
- In-Reply-To
- <20170620191951.84791-1-bmwill@google.com>
'GIT_TOPLEVEL_PREFIX_ENVIRONMENT' was added in (b58a68c1c setup: allow for prefix to be passed to git commands) to aid in fixing a bug where 'ls-files' and 'grep' were not able to properly recurse when called from within a subdirectory. Add a 'NEEDSWORK' comment indicating that this envvar should be removed once 'ls-files' and 'grep' can recurse in-process.
Signed-off-by: Brandon Williams <bmwill@google.com> --- setup.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/setup.c b/setup.c index 24a738b0d..b477faa44 100644 --- a/setup.c +++ b/setup.c @@ -1079,6 +1079,12 @@ const char *setup_git_directory_gently(int *nongit_ok) die("BUG: unhandled setup_git_directory_1() result"); } + /* + * NEEDSWORK: This was a hack in order to get ls-files and grep to have + * properly formated output when recursing submodules. Once ls-files + * and grep have been changed to perform this recursing in-process this + * needs to be removed. + */ env_prefix = getenv(GIT_TOPLEVEL_PREFIX_ENVIRONMENT); if (env_prefix) prefix = env_prefix;
-- 2.13.1.611.g7e3b11ae1-goog