Re: [PATCH v3 15/20] repository: add index_state to struct repo
- From
- Brandon Williams <bmwill@google.com>
- Date
- Jun 21, 2017, 22:54 UTC
- Message-ID
- <20170621225403.GH53348@google.com>
- In-Reply-To
- <20170621155059.3ae2c601@twelve2.svl.corp.google.com>
On 06/21, Jonathan Tan wrote:
Show 9 quoted lines
> On Tue, 20 Jun 2017 12:19:46 -0700
> Brandon Williams <bmwill@google.com> wrote:
>
> > +int repo_read_index(struct repository *repo)
> > +{
> > + if (!repo->index)
> > + repo->index = xcalloc(1, sizeof(struct index_state));
>
> sizeof(*repo->index)?Is there a reason to prefer one versus the other? Either way I can change.
Show 8 quoted lines
> > [snip] > > > + /* Repository's in-memory index */ > > + struct index_state *index; > > + > > Might be worth commenting that repo_read_index() can populate this.
-- Brandon Williams