Re: [PATCH] mingw: allow hooks to be .exe files
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 30, 2017, 12:29 UTC
- Message-ID
- <alpine.DEB.2.20.1701301328390.3469@virtualbox>
- In-Reply-To
- <CAGZ79kaa5WJmZkyFROfkfNb3++t37qAuAebKJTon2iD2bh+sWw@mail.gmail.com>
Hi Stefan,
On Fri, 27 Jan 2017, Stefan Beller wrote:
Show 18 quoted lines
> On Fri, Jan 27, 2017 at 2:29 AM, Johannes Schindelin > <Johannes.Schindelin@gmx.de> wrote: > > Hi Junio, > > > > On Thu, 26 Jan 2017, Junio C Hamano wrote: > > > >> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > >> > >> > On Wed, 25 Jan 2017, Jeff King wrote: > >> > > >> > v2 coming, > > The commit message, while technically correct, seems a bit off. This is > because the commit message only talks about .exe extensions, but the > change in code doesn't even have the string "exe" mentioned once. > > With this discussion here, it is easy for me to connect the dots, but it > would be nice to have the full picture in the commit message.
I just sent out v3, using a slightly tweaked version of the commit message you proposed.
Ciao, Dscho