Re: [PATCH] mingw: allow hooks to be .exe files

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 27, 2017, 10:29 UTC
Message-ID: <alpine.DEB.2.20.1701271127520.3469@virtualbox>
In-Reply-To: <xmqq4m0l64pg.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Thu, 26 Jan 2017, Junio C Hamano wrote:

Show 21 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Wed, 25 Jan 2017, Jeff King wrote:
> >
> >> On Wed, Jan 25, 2017 at 05:58:42PM +0100, Johannes Schindelin wrote:
> >> 
> >> > -	if (access(path.buf, X_OK) < 0)
> >> > +	if (access(path.buf, X_OK) < 0) {
> >> > +#ifdef STRIP_EXTENSION
> >> > +		strbuf_addstr(&path, ".exe");
> >> 
> >> I think STRIP_EXTENSION is a string.  Should this line be:
> >> 
> >>   strbuf_addstr(&path, STRIP_EXTENSION);
> >
> > Yep.
> >
> > v2 coming,
> > Johannes
> 
> I think I've already tweaked it out when I queued the original one.

After digging, I found your SQUASH commit. I had not known about that.

In any case, I much rather prefer to have the final version of any patch or patch series I contribute to be identical between what you commit and what I sent to the mailing list. We do disagree from time to time, and I would like to have the opportunity of reviewing how you tweak my changes.

Ciao, Johannes