Re: [PATCH] mingw: allow hooks to be .exe files

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 26, 2017, 12:21 UTC
Message-ID: <alpine.DEB.2.20.1701261321010.3469@virtualbox>
In-Reply-To: <20170125211529.jq4halip4ndbff5k@sigill.intra.peff.net>

Hi Peff,

On Wed, 25 Jan 2017, Jeff King wrote:

Show 10 quoted lines

> On Wed, Jan 25, 2017 at 05:58:42PM +0100, Johannes Schindelin wrote:
> 
> > -	if (access(path.buf, X_OK) < 0)
> > +	if (access(path.buf, X_OK) < 0) {
> > +#ifdef STRIP_EXTENSION
> > +		strbuf_addstr(&path, ".exe");
> 
> I think STRIP_EXTENSION is a string.  Should this line be:
> 
>   strbuf_addstr(&path, STRIP_EXTENSION);

Yep.

v2 coming, Johannes