Re: [PATCH v2] t6026-merge-attr: don't fail if sleep exits early

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 10, 2016, 21:55 UTC
Message-ID: <alpine.DEB.2.20.1611102254340.24684@virtualbox>
In-Reply-To: <xmqqbmxn6t11.fsf@gitster.mtv.corp.google.com>

Hi all,

On Thu, 10 Nov 2016, Junio C Hamano wrote:

Show 16 quoted lines

> Andreas Schwab <schwab@suse.de> writes:
> 
> > Commit 5babb5bdb3 ("t6026-merge-attr: clean up background process at end
> > of test case") added a kill command to clean up after the test, but this
> > can fail if the sleep command exits before the cleanup is executed.
> > Ignore the error from the kill command.
> >
> > Explicitly check for the existence of the pid file to test that the merge
> > driver was actually called.
> >
> > Signed-off-by: Andreas Schwab <schwab@suse.de>
> > ---
> 
> OK.  sleep.pid is a reasonable easy-to-access side effect we can
> observe to make sure that the sleep-one-second merge driver was
> indeed invoked, which was missing from the earlier round.

No, this is incorrect. The condition that we need to know applies is that the script is still running, and blocking if the bug reappears.

It is not enough to test that the script *started* running. If it exits too early, the problematic condition is never tested, and the test is useless.

Ciao, Johannes