git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t6026-merge-attr: don't fail if sleep exits early

From
Jeff King <peff@peff.net>
Date
Nov 9, 2016, 15:31 UTC
Message-ID
<20161109153128.aqm2lgdntdlycnaq@sigill.intra.peff.net>
In-Reply-To
<mvmzil8btzb.fsf@hawking.suse.de>
On Wed, Nov 09, 2016 at 03:36:40PM +0100, Andreas Schwab wrote:
Show 7 quoted lines
> On Nov 09 2016, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> 
> > The reason why we do not ignore kill errors is that we want to make sure
> > that the script *actually ran*. Otherwise, the thing we need to test here
> > does not necessarily get tested.
> 
> That can be tested by looking for the pid file.

I agree that makes the intent a lot more obvious. Having a necessary condition of the test stuffed into a test_when_finished block seems counter-intuitive.

-Peff
Previous: Andreas SchwabNext: Andreas Schwab
Message 5 of 12 in “t6026-merge-attr: don't fail if sleep exits early”
  1. t6026-merge-attr: don't fail if sleep exits earlyAndreas Schwab, Nov 8, 2016
  2. Jeff KingNov 8, 2016
  3. Johannes SchindelinNov 9, 2016
  4. Andreas SchwabNov 9, 2016
  5. Jeff KingNov 9, 2016
  6. t6026-merge-attr: don't fail if sleep exits earlyAndreas Schwab, Nov 10, 2016
  7. Junio C HamanoNov 10, 2016
  8. Johannes SchindelinNov 10, 2016
  9. Junio C HamanoNov 10, 2016
  10. Jeff KingNov 10, 2016
  11. Junio C HamanoNov 10, 2016
  12. Jeff KingNov 10, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.