git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] t6026-merge-attr: don't fail if sleep exits early

From
Jeff King <peff@peff.net>
Date
Nov 10, 2016, 22:35 UTC
Message-ID
<20161110223522.4b35ojaz5nhk4sll@sigill.intra.peff.net>
In-Reply-To
<xmqq60nv55o3.fsf@gitster.mtv.corp.google.com>
On Thu, Nov 10, 2016 at 02:30:36PM -0800, Junio C Hamano wrote:
Show 8 quoted lines
> As everybody knows there is no appropriate timeout value that is
> good for everybody.  I wonder if we can replace the sleep 1 with
> something like
> 
> 	( while sleep 3600; do :; done ) &
> 
> so that leaked fd will be kept even in any heavily loaded
> environment instead?
I think you may have missed:
  http://public-inbox.org/git/16dc9f159b214997f7501006a8d1d8be2ef858e8.1478699463.git.johannes.schindelin@gmx.de/

which does roughly that. It does not loop, but I suspect 3600 is plenty in practice.

I do think the test would be a lot more obvious if it confirmed at the end of the test that the process was still running, as opposed to relying on test_when_finished to check it.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 12 in “t6026-merge-attr: don't fail if sleep exits early”
  1. t6026-merge-attr: don't fail if sleep exits earlyAndreas Schwab, Nov 8, 2016
  2. Jeff KingNov 8, 2016
  3. Johannes SchindelinNov 9, 2016
  4. Andreas SchwabNov 9, 2016
  5. Jeff KingNov 9, 2016
  6. t6026-merge-attr: don't fail if sleep exits earlyAndreas Schwab, Nov 10, 2016
  7. Junio C HamanoNov 10, 2016
  8. Johannes SchindelinNov 10, 2016
  9. Junio C HamanoNov 10, 2016
  10. Jeff KingNov 10, 2016
  11. Junio C HamanoNov 10, 2016
  12. Jeff KingNov 10, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.