Re: [PATCH 10/11] run command: add RUN_COMMAND_NO_STDOUT

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 18, 2016, 19:22 UTC
Message-ID: <alpine.DEB.2.20.1609182118380.129229@virtualbox>
In-Reply-To: <xmqq37kzigvf.fsf@gitster.mtv.corp.google.com>

Hi,

On Fri, 16 Sep 2016, Junio C Hamano wrote:

Show 10 quoted lines

> Kevin Wern <kevin.m.wern@gmail.com> writes:
> 
> > Add option RUN_COMMAND_NO_STDOUT, which sets no_stdout on a child
> > process.
> >
> > This will be used by git clone when calling index-pack on a downloaded
> > packfile.
> 
> If it is just one caller, would't it make more sense for that caller
> set no_stdout explicitly itself?

Taking a step back, maybe it is not such a good idea to swallow the output in all cases, including the error cases?

Maybe the best course of action is to hide stdout/stderr by default but show it in case of a non-zero exit code, i.e. using https://public-inbox.org/git/6383b7afcdeb6c999862aa32ba437997f2dd3d4e.1472633606.git.johannes.schindelin@gmx.de/ ?

Ciao, Dscho