Re: [PATCH 10/11] run command: add RUN_COMMAND_NO_STDOUT
- From
- Kevin Wern <kevin.m.wern@gmail.com>
- Date
- Sep 28, 2016, 04:46 UTC
- Message-ID
- <20160928044622.GE3762@kwern-HP-Pavilion-dv5-Notebook-PC>
- In-Reply-To
- <xmqq37kzigvf.fsf@gitster.mtv.corp.google.com>
On Fri, Sep 16, 2016 at 04:07:00PM -0700, Junio C Hamano wrote:
Show 10 quoted lines
> Kevin Wern <kevin.m.wern@gmail.com> writes: > > > Add option RUN_COMMAND_NO_STDOUT, which sets no_stdout on a child > > process. > > > > This will be used by git clone when calling index-pack on a downloaded > > packfile. > > If it is just one caller, would't it make more sense for that caller > set no_stdout explicitly itself?
I based the calling code in do_index_pack on dissociate_from_references, which uses run_command_v_opt, so it never occured to me to do that. I thought it was just good, uniform style and encapsulation. Like how transport's methods and internals aren't really intended to be changed or accessed--unless it's through the APIs we create.
However, I don't feel very strongly about this, so I'm okay with this change.