Re: [PATCH 02/11] Resumable clone: add prime-clone endpoints

From: Duy Nguyen <pclouds@gmail.com>
Date: Sep 19, 2016, 13:15 UTC
Message-ID: <CACsJy8ARu_PkduP-McnE26OFEgr_YAkLtmfaxwYX7i9m47mJmg@mail.gmail.com>
In-Reply-To: <1473984742-12516-3-git-send-email-kevin.m.wern@gmail.com>

On Fri, Sep 16, 2016 at 7:12 AM, Kevin Wern <kevin.m.wern@gmail.com> wrote:

Show 6 quoted lines

>  static struct daemon_service daemon_service[] = {
>         { "upload-archive", "uploadarch", upload_archive, 0, 1 },
>         { "upload-pack", "uploadpack", upload_pack, 1, 1 },
>         { "receive-pack", "receivepack", receive_pack, 0, 1 },
> +       { "prime-clone", "primeclone", prime_clone, 0, 1 },
>  };

I guess this is why you chose to implement a new command in 01/11, simpler to be called from http-backend?

> +               // prime-clone does not need --stateless-rpc and
> +               // --advertise-refs options. Maybe it will in the future, but
> +               // until then it seems best to do this instead of adding
> +               // "dummy" options.

Stick to /* .. */

> +               if (strcmp(svc->name, "prime-clone") != 0) {
> +                       argv_array_pushl(&argv, "--stateless-rpc",
> +                                        "--advertise-refs", NULL);
> +               }

We also have an exception for select_getanyfile() below. I think it's time we add a function callback in struct rpc_service to run each service the way they want. Then prime-clone won't need an exception (neither does select_anyfile, mostly)

-- 
Duy