Re: [PATCH] compat: move strdup(3) replacement to its own file
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 8, 2016, 06:59 UTC
- Message-ID
- <alpine.DEB.2.20.1609080859160.129229@virtualbox>
- In-Reply-To
- <xmqqfupbob9c.fsf@gitster.mtv.corp.google.com>
Hi,
On Wed, 7 Sep 2016, Junio C Hamano wrote:
Show 18 quoted lines
> René Scharfe <l.s.r@web.de> writes: > > > Well, OK. I think the missing point is that the original nedmalloc > > doesn't come with strdup() and doesn't need it. Only _users_ of > > nedmalloc need it. Marius added it in nedmalloc.c, but strdup.c is a > > better place for it. > > Thanks. I'll add these lines like so: > > Move our implementation of strdup(3) out of compat/nedmalloc/ and > allow it to be used independently from USE_NED_ALLOCATOR. The > original nedmalloc doesn't come with strdup() and doesn't need it. > Only _users_ of nedmalloc need it, which was added when we imported > it to our compat/ hierarchy. > > This reduces the difference of our copy of nedmalloc from the > original, making it easier to update, and allows for easier testing > and reusing of our version of strdup().
Excellent!
Thanks, Dscho