Re: [PATCH] compat: move strdup(3) replacement to its own file

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 4, 2016, 07:46 UTC
Message-ID: <alpine.DEB.2.20.1609040941210.129229@virtualbox>
In-Reply-To: <89725a44-8afa-1eb1-732a-23b1e264616c@web.de>

Hi René,

I imagine you Cc:ed me because the nedmalloc stuff came in via the Windows port, contributed by Marius (who is no longer active on the Git project because it works well enough for him)?

On Sat, 3 Sep 2016, René Scharfe wrote:

Show 5 quoted lines

> Move our implementation of strdup(3) out of compat/nedmalloc/ and allow
> it to be used independently from USE_NED_ALLOCATOR.  This reduces the
> difference of our copy of nedmalloc from the original, making it easier
> to update, and allows for easier testing and reusing of our version of
> strdup().

I would like to suggest an additional paragraph to explain why we do not need to #include "git-compat-util.h" in nedmalloc from now on:

	Please note that nedmalloc never actually uses strdup() itself,
	therefore we need not enforce gitstrdup() usage in nedmalloc.c.

The patch looks quite straight-forward otherwise. (Junio, if you want an ACK from me, you hereby got it).

Thanks! Dscho