Re: [PATCH] compat: move strdup(3) replacement to its own file

From: René Scharfe <l.s.r@web.de>
Date: Sep 6, 2016, 15:40 UTC
Message-ID: <6926b39c-4448-c463-33f7-d9eae841c635@web.de>
In-Reply-To: <alpine.DEB.2.20.1609040941210.129229@virtualbox>

Am 04.09.2016 um 09:46 schrieb Johannes Schindelin:

Show 5 quoted lines

> Hi René,
>
> I imagine you Cc:ed me because the nedmalloc stuff came in via the Windows
> port, contributed by Marius (who is no longer active on the Git project
> because it works well enough for him)?

Kind of; it's also a follow-up to the recent discussion you started about compiler warnings in that code.

Show 13 quoted lines

> On Sat, 3 Sep 2016, René Scharfe wrote:
>
>> Move our implementation of strdup(3) out of compat/nedmalloc/ and allow
>> it to be used independently from USE_NED_ALLOCATOR.  This reduces the
>> difference of our copy of nedmalloc from the original, making it easier
>> to update, and allows for easier testing and reusing of our version of
>> strdup().
>
> I would like to suggest an additional paragraph to explain why we do not
> need to #include "git-compat-util.h" in nedmalloc from now on:
>
> 	Please note that nedmalloc never actually uses strdup() itself,
> 	therefore we need not enforce gitstrdup() usage in nedmalloc.c.

Well, OK. I think the missing point is that the original nedmalloc doesn't come with strdup() and doesn't need it. Only _users_ of nedmalloc need it. Marius added it in nedmalloc.c, but strdup.c is a better place for it.

René