Re: [PATCH] revert: clarify seemingly bogus OPT_END repetition

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 6, 2016, 07:28 UTC
Message-ID: <alpine.DEB.2.20.1607060906550.6426@virtualbox>
In-Reply-To: <20160705204447.GB14496@sigill.intra.peff.net>

Hi Peff,

On Tue, 5 Jul 2016, Jeff King wrote:

Show 6 quoted lines

> +	ALLOC_ARRAY(ret, st_add3(a_len, b_len, 1));
> +	for (i = 0; i < a_len; i++)
> +		ret[i] = a[i];
> +	for (i = 0; i < b_len; i++)
> +		ret[a_len + i] = b[i];
> +	ret[a_len + b_len] = b[b_len]; /* final OPTION_END */

Not really a big deal, but I'd have written "i <= b_len" in the for loop and avoided the final line. However, your version is clearer.

Ciao, Dscho