Re: [PATCH] revert: clarify seemingly bogus OPT_END repetition

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 6, 2016, 07:03 UTC
Message-ID: <alpine.DEB.2.20.1607060901430.6426@virtualbox>
In-Reply-To: <20160705202820.GA14496@sigill.intra.peff.net>

Hi Peff,

On Tue, 5 Jul 2016, Jeff King wrote:

Show 10 quoted lines

> By the way, I notice that the error message when concat fails is just:
> 
>   if (parse_options_concat(options, ARRAY_SIZE(options), cp_extra))
> 	die(_("program error"));
> 
> Should this become:
> 
>         die("BUG: not enough room to concatenate options");
> 
> as part of your BUG cleanups elsewhere?

Not really. I do not have time for a crusade through all of the die() statements to determine whether they're really bug reports. You refer to my clean-up of merge-recursive.c, right? That was a necessary prerequisite for the patch to stop die()ing in case of errors.

Ciao, Dscho