Re: [PATCH] t9100: fix breakage when SHELL_PATH is not /bin/sh
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 8, 2016, 19:31 UTC
- Message-ID
- <alpine.DEB.2.20.1602082027550.2964@virtualbox>
- In-Reply-To
- <20160208163700.GA22929@sigill.intra.peff.net>
Hi,
On Mon, 8 Feb 2016, Jeff King wrote:
> Assuming your patch works on Windows
If it re-introduces that chmod +x, it won't.
Please note that my *original* patch actually only guarded the chmod +x, but Junio suggested switching to write_script and since it passed the test suite here, I though it would be safe.
I still think write_script is the better alternative.
So why not just prefix it with `SHELL_PATH=/bin/sh`?
-- snipsnap -- t a/t/t9100-git-svn-basic.sh b/t/t9100-git-svn-basic.sh index 56acc1e..6ad8537 100755
--- a/t/t9100-git-svn-basic.sh +++ b/t/t9100-git-svn-basic.sh @@ -30,7 +30,7 @@ test_expect_success \ echo "deep dir" >dir/a/b/c/d/e/file && mkdir bar && echo "zzz" >bar/zzz && - write_script exec.sh </dev/null && + SHELL_PATH=/bin/sh write_script exec.sh </dev/null && svn_cmd import -m "import for git svn" . "$svnrepo" >/dev/null ) && rm -rf import &&