git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t9100: fix breakage when SHELL_PATH is not /bin/sh

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Feb 7, 2016, 19:11 UTC
Message-ID
<982f6f499c988e1063275e2951c9856d622a83f3.1454872161.git.git@drmicha.warpmail.net>

bcb11f1 (mingw: mark t9100's test cases with appropriate prereqs, 2016-01-27) replaced "/bin/sh" in exec.sh by the shell specified in SHELL_PATH, but that breaks the subtest which checks for a specific checksum of a tree containing.

Revert that change that was not explained in the commit message anyways (exec.sh is never executed).

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
 t/t9100-git-svn-basic.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t9100-git-svn-basic.sh b/t/t9100-git-svn-basic.sh
index 5464b5b..936913c 100755
--- a/t/t9100-git-svn-basic.sh
+++ b/t/t9100-git-svn-basic.sh
@@ -30,7 +30,8 @@ test_expect_success \
 		echo "deep dir" >dir/a/b/c/d/e/file &&
 		mkdir bar &&
 		echo "zzz" >bar/zzz &&
-		write_script exec.sh </dev/null &&
+		echo "#!/bin/sh" >exec.sh &&
+		chmod +x exec.sh &&
 		svn_cmd import -m "import for git svn" . "$svnrepo" >/dev/null
 	) &&
 	rm -rf import &&
-- 
2.7.0.373.g083f1fe
Next: Jeff King
Message 1 of 13 in “t9100: fix breakage when SHELL_PATH is not /bin/sh”
  1. t9100: fix breakage when SHELL_PATH is not /bin/shMichael J Gruber, Feb 7, 2016
  2. Jeff KingFeb 8, 2016
  3. Michael J GruberFeb 8, 2016
  4. Jeff KingFeb 8, 2016
  5. Johannes SchindelinFeb 8, 2016
  6. Jeff KingFeb 8, 2016
  7. Junio C HamanoFeb 8, 2016
  8. Jeff KingFeb 8, 2016
  9. Johannes SchindelinFeb 9, 2016
  10. Junio C HamanoFeb 9, 2016
  11. Johannes SchindelinFeb 8, 2016
  12. Junio C HamanoFeb 8, 2016
  13. Johannes SchindelinFeb 9, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.