git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t9100: fix breakage when SHELL_PATH is not /bin/sh

From
Jeff King <peff@peff.net>
Date
Feb 8, 2016, 13:50 UTC
Message-ID
<20160208135013.GA27054@sigill.intra.peff.net>
In-Reply-To
<982f6f499c988e1063275e2951c9856d622a83f3.1454872161.git.git@drmicha.warpmail.net>
On Sun, Feb 07, 2016 at 08:11:37PM +0100, Michael J Gruber wrote:
Show 7 quoted lines
> bcb11f1 (mingw: mark t9100's test cases with appropriate prereqs, 2016-01-27)
> replaced "/bin/sh" in exec.sh by the shell specified in SHELL_PATH, but
> that breaks the subtest which checks for a specific checksum of a tree
> containing.
> 
> Revert that change that was not explained in the commit message anyways
> (exec.sh is never executed).

I think this just re-breaks things on Windows. That first setup test used "chmod +x" (which is brought back by your patch), without having the POSIXPERM prerequisite.

We probably do not want to mark the whole setup test as POSIXPERM, as that would effectively break all of the other tests on Windows. The rest of the tests need to be able to work whether or not the "chmod +x" was run. It may be simpler to just break the executable-bit tests, including setup, out to their own section of the script.

That being said, t9100 seems to pass for me, even at bcb11f1. Can you show us the breakage you are seeing?

-Peff
Previous: Michael J GruberNext: Michael J Gruber
Message 2 of 13 in “t9100: fix breakage when SHELL_PATH is not /bin/sh”
  1. t9100: fix breakage when SHELL_PATH is not /bin/shMichael J Gruber, Feb 7, 2016
  2. Jeff KingFeb 8, 2016
  3. Michael J GruberFeb 8, 2016
  4. Jeff KingFeb 8, 2016
  5. Johannes SchindelinFeb 8, 2016
  6. Jeff KingFeb 8, 2016
  7. Junio C HamanoFeb 8, 2016
  8. Jeff KingFeb 8, 2016
  9. Johannes SchindelinFeb 9, 2016
  10. Junio C HamanoFeb 9, 2016
  11. Johannes SchindelinFeb 8, 2016
  12. Junio C HamanoFeb 8, 2016
  13. Johannes SchindelinFeb 9, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.