git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] Fix $((...)) coding style

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 4, 2016, 12:38 UTC
Message-ID
<alpine.DEB.2.20.1602041334450.2964@virtualbox>
In-Reply-To
<20160204121437.GF29880@serenity.lan>
Hi John,
On Thu, 4 Feb 2016, John Keeping wrote:
> Using spaces around operators also matches our C coding style.
Well, by that reasoning you should go the whole nine yards and write
	lineno = $(( $lineno + 1 ))
Except you can't. Because shell code is inherently not like C code.

What I found particularly interesting about 180bad3 (rebase -i: respect core.commentchar, 2013-02-11) was that it *snuck in* that coding style: it *changed* the existing one (without rationale in the commit message, too).

Ciao, Johannes

Previous: John KeepingNext: John Keeping
Message 6 of 13 in “Fix $((...)) coding style”
  1. 0/3 Fix $((...)) coding styleJohannes Schindelin, Feb 4, 2016
  2. 1/3 filter-branch: fix style of $((...) constructJohannes Schindelin, Feb 4, 2016
  3. 2/3 rebase--interactive: adjust the coding style of $((...))Johannes Schindelin, Feb 4, 2016
  4. 3/3 rebase --merge: adjust $((...)) coding styleJohannes Schindelin, Feb 4, 2016
  5. John KeepingFeb 4, 2016
  6. Johannes SchindelinFeb 4, 2016
  7. John KeepingFeb 4, 2016
  8. Johannes SchindelinFeb 4, 2016
  9. John KeepingFeb 4, 2016
  10. Johannes SchindelinFeb 4, 2016
  11. John KeepingFeb 4, 2016
  12. Junio C HamanoFeb 4, 2016
  13. Junio C HamanoFeb 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.