From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 04 Feb 2016 12:38:51 GMT
Subject: Re: [PATCH 0/3] Fix $((...)) coding style
Message-ID: <alpine.DEB.2.20.1602041334450.2964@virtualbox>
In-Reply-To: <20160204121437.GF29880@serenity.lan>

Hi John,

On Thu, 4 Feb 2016, John Keeping wrote:

> Using spaces around operators also matches our C coding style.

Well, by that reasoning you should go the whole nine yards and write

	lineno = $(( $lineno + 1 ))

Except you can't. Because shell code is inherently not like C code.

What I found particularly interesting about 180bad3 (rebase -i: respect
core.commentchar, 2013-02-11) was that it *snuck in* that coding style: it
*changed* the existing one (without rationale in the commit message, too).

Ciao,
Johannes