git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] Fix $((...)) coding style

From
John Keeping <john@keeping.me.uk>
Date
Feb 4, 2016, 12:14 UTC
Message-ID
<20160204121437.GF29880@serenity.lan>
In-Reply-To
<cover.1454587284.git.johannes.schindelin@gmx.de>
On Thu, Feb 04, 2016 at 01:01:39PM +0100, Johannes Schindelin wrote:
Show 11 quoted lines
> I noticed through a nearby patch series that was submitted by Elia that
> some of the $((...)) expressions introduced in scripts that I introduced
> to Git's source code did not match the existing code's convention:
> previously these expressions did not contain any spaces, now *some* do.
> 
> This patch series tries to clean that up quickly before even more code
> has to decide which one of the disagreeing coding conventions to use.
> 
> Note: For the sake of getting this patch series out, I skipped t/ and
> contrib/. I do not care much about the latter, but t/ should probably be
> fixed, too.

Should this be going this other way (i.e. standardising on having the spaces)?

The current state (excluding contrib/ and t/) seems to favour spaces:

$ git grep '\$((' -- ':/' ':!t/' ':!contrib/' Documentation/CodingGuidelines: - We use Arithmetic Expansion $(( ... )). Documentation/CodingGuidelines: of them, as some shells do not grok $((x)) while accepting $(($x)) generate-cmdlist.sh: n=$(($n+1)) git-filter-branch.sh: elapsed=$(($now - $start_timestamp)) git-filter-branch.sh: remaining=$(( ($commits - $count) * $elapsed / $count )) git-filter-branch.sh: next_sample_at=$(( ($elapsed + 1) * $count / $elapsed )) git-filter-branch.sh: next_sample_at=$(($next_sample_at + 1)) git-filter-branch.sh: git_filter_branch__commit_count=$(($git_filter_branch__commit_count+1)) git-rebase--interactive.sh: total=$(($new_count + $(git stripspace --strip-comments <"$todo" | wc -l))) git-rebase--interactive.sh: count=$(($(sed -n \ git-rebase--interactive.sh: lineno=$(( $lineno + 1 )) git-rebase--merge.sh: msgnum=$(($msgnum + 1)) git-rebase--merge.sh: eval GITHEAD_$cmt='"${cmt_name##refs/heads/}~$(($end - $msgnum))"' git-rebase--merge.sh: msgnum=$(($msgnum + 1)) git-rebase--merge.sh: msgnum=$(($msgnum + 1)) git-submodule.sh: n=$(($1 + 0)) 2>/dev/null && test "$n" = "$1" git-submodule.sh: total_commits=" ($(($total_commits + 0)))"

I make that 3 without spaces (including the git-rebase--interactive.sh case that wraps) and 12 that do have spaces around operators. Using spaces around operators also matches our C coding style.

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 5 of 13 in “Fix $((...)) coding style”
  1. 0/3 Fix $((...)) coding styleJohannes Schindelin, Feb 4, 2016
  2. 1/3 filter-branch: fix style of $((...) constructJohannes Schindelin, Feb 4, 2016
  3. 2/3 rebase--interactive: adjust the coding style of $((...))Johannes Schindelin, Feb 4, 2016
  4. 3/3 rebase --merge: adjust $((...)) coding styleJohannes Schindelin, Feb 4, 2016
  5. John KeepingFeb 4, 2016
  6. Johannes SchindelinFeb 4, 2016
  7. John KeepingFeb 4, 2016
  8. Johannes SchindelinFeb 4, 2016
  9. John KeepingFeb 4, 2016
  10. Johannes SchindelinFeb 4, 2016
  11. John KeepingFeb 4, 2016
  12. Junio C HamanoFeb 4, 2016
  13. Junio C HamanoFeb 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.