Re: [PATCH v2 2/2] Handle more file writes correctly in shared repos

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 8, 2016, 16:05 UTC
Message-ID: <alpine.DEB.2.20.1601081704280.2964@virtualbox>
In-Reply-To: <xmqq1t9t3vn8.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Thu, 7 Jan 2016, Junio C Hamano wrote:

Show 7 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > - git apply, when writing rejected hunks
> 
> Today I may try to apply and leave hello.c.rej; tomorrow you may try to
> apply a different patch and get rejection for the same file.  And you
> would not be able to if my umask is 077.

As I just wrote in my reply to Peff: my experience with .rej files is that I want to inspect them, and then delete them once I addressed them. I do not want anybody to interfere with that, as the presence of .rej files serves also as a TODO list.

> > - git fast-import, when writing a crash report
> 
> I am not sure about this one.  Is the crash report designed to get
> unique filename every time you run?

Yes, the pid is part of the file name. So we're golden.

Ciao, Dscho