Re: [PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree
On Wed, 25 Oct 2017, Alex Vandiver wrote:
Show 22 quoted lines
> The fsmonitor command inherits the PWD of its caller, which may be
> anywhere in the working copy. This makes is difficult for the
> fsmonitor command to operate on the whole repository. Specifically,
> for the watchman integration, this causes each subdirectory to get its
> own watch entry.
>
> Set the CWD to the top of the working directory, for consistency.
>
> Signed-off-by: Alex Vandiver <alexmv@dropbox.com>
> ---
> fsmonitor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fsmonitor.c b/fsmonitor.c
> index 7c1540c05..0d26ff34f 100644
> --- a/fsmonitor.c
> +++ b/fsmonitor.c
> @@ -121,6 +121,7 @@ static int query_fsmonitor(int version, uint64_t last_update, struct strbuf *que
> argv[3] = NULL;
> cp.argv = argv;
> cp.use_shell = 1;
> + cp.dir = get_git_work_tree();
Looks like my editor swapped out a tab on me. I'll hold off on
sending a revised version to collect any other comments.
- Alex