git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree

From
AVAlex Vandiver <alexmv@dropbox.com>
Date
Oct 26, 2017, 01:31 UTC
Message-ID
<9af6d28ef43edbc99a9b7a9c41990de0989bfc76.1508981451.git.alexmv@dropbox.com>
In-Reply-To
<20171026013117.30034-1-alexmv@dropbox.com>

The fsmonitor command inherits the PWD of its caller, which may be anywhere in the working copy. This makes is difficult for the fsmonitor command to operate on the whole repository. Specifically, for the watchman integration, this causes each subdirectory to get its own watch entry.

Set the CWD to the top of the working directory, for consistency.
Signed-off-by: Alex Vandiver <alexmv@dropbox.com>
---
 fsmonitor.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/fsmonitor.c b/fsmonitor.c
index 7c1540c05..0d26ff34f 100644
--- a/fsmonitor.c
+++ b/fsmonitor.c
@@ -121,6 +121,7 @@ static int query_fsmonitor(int version, uint64_t last_update, struct strbuf *que
 	argv[3] = NULL;
 	cp.argv = argv;
 	cp.use_shell = 1;
+        cp.dir = get_git_work_tree();
 
 	return capture_command(&cp, query_result, 1024);
 }
-- 
2.15.0.rc1.413.g76aedb451
Previous: Alex VandiverNext: Alex Vandiver
Message 2 of 17 in “fsmonitor fixes”
  1. 0/4 fsmonitor fixesAlex Vandiver, Oct 26, 2017
  2. 1/4 fsmonitor: Set the PWD to the top of the working treeAlex Vandiver, Oct 26, 2017
  3. Alex VandiverOct 26, 2017
  4. Ben PeartOct 26, 2017
  5. Alex VandiverOct 26, 2017
  6. Ben PeartOct 27, 2017
  7. Alex VandiverOct 27, 2017
  8. Johannes SchindelinOct 29, 2017
  9. 2/4 fsmonitor: Don't bother pretty-printing JSON from watchmanAlex Vandiver, Oct 26, 2017
  10. Ben PeartOct 26, 2017
  11. Ben PeartOct 26, 2017
  12. Alex VandiverOct 26, 2017
  13. Ben PeartOct 27, 2017
  14. 3/4 fsmonitor: Document GIT_TRACE_FSMONITORAlex Vandiver, Oct 26, 2017
  15. 4/4 fsmonitor: Delay updating state until after split index is mergedAlex Vandiver, Oct 26, 2017
  16. Ben PeartOct 26, 2017
  17. Johannes SchindelinOct 29, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.