Re: [PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree

From: Ben Peart <peartben@gmail.com>
Date: Oct 26, 2017, 19:56 UTC
Message-ID: <5a389621-961d-48e3-339a-ef182d3ed628@gmail.com>
In-Reply-To: <9af6d28ef43edbc99a9b7a9c41990de0989bfc76.1508981451.git.alexmv@dropbox.com>

On 10/25/2017 9:31 PM, Alex Vandiver wrote:

Show 23 quoted lines

> The fsmonitor command inherits the PWD of its caller, which may be
> anywhere in the working copy.  This makes is difficult for the
> fsmonitor command to operate on the whole repository.  Specifically,
> for the watchman integration, this causes each subdirectory to get its
> own watch entry.
> 
> Set the CWD to the top of the working directory, for consistency.
> 
> Signed-off-by: Alex Vandiver <alexmv@dropbox.com>
> ---
>   fsmonitor.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/fsmonitor.c b/fsmonitor.c
> index 7c1540c05..0d26ff34f 100644
> --- a/fsmonitor.c
> +++ b/fsmonitor.c
> @@ -121,6 +121,7 @@ static int query_fsmonitor(int version, uint64_t last_update, struct strbuf *que
>   	argv[3] = NULL;
>   	cp.argv = argv;
>   	cp.use_shell = 1;
> +        cp.dir = get_git_work_tree();
>

I'm not sure what would trigger this problem but I don't doubt that it is possible. Better to be safe than sorry. This is a better/faster solution than you're previous patch. Thank you!

>   	return capture_command(&cp, query_result, 1024);
>   }
>