Re: [PATCH/RFC] Allow curl to rewind the RPC read buffer at any time
- From
Martin Storsjö <martin@martin.st>
- Date
- Dec 2, 2009, 09:32 UTC
- Message-ID
- <alpine.DEB.2.00.0912021130300.5582@cone.home.martin.st>
- In-Reply-To
- <alpine.DEB.2.00.0912021011430.19179@tvnag.unkk.fr>
On Wed, 2 Dec 2009, Daniel Stenberg wrote:
Show 13 quoted lines
> On Wed, 2 Dec 2009, Tay Ray Chuan wrote: > > > According to Martin, Expect: 100-continue is not working due to libcurl. > > Right, that is/was a bug in how libcurl behaves when the application itself > has set the "Expect: 100-continue" header. Martin has provided a fix for that > for the next libcurl version though, but that won't make a lot of existing > users happy. > > Thinking about this particular problem, what is the motivation for git to > forcily add that header in the first place? I mean, libcurl does add the > header by itself when it thinks it is necessary and then it handles it > correctly.
As far as I saw, the reason for it being manually added is that curl actually didn't add it automatically in that case. That was the reason for the second patch/rfc thread that I sent to curl-library (where postsize == 0, as in unknown, didn't trigger the addition of any Expect header).
// Martin