Re: [PATCH/RFC] Allow curl to rewind the RPC read buffer
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Dec 1, 2009, 16:01 UTC
- Message-ID
- <20091201160150.GB21299@spearce.org>
- In-Reply-To
- <alpine.DEB.2.00.0912011232450.5582@cone.home.martin.st>
Martin Storsj? <martin@martin.st> wrote:
> When using multi-pass authentication methods, the curl library may need > to rewind the read buffers used for providing data to HTTP POST, if data > has been output before a 401 error is received.
In theory, since the cURL session stays active, we would have received the 401 authentication error during the initial "GET $GIT_DIR/info/refs?service=git-$service" request, and the subsequent "POST $GIT_DIR/git-$service" requests would automatically include the authentication data.
That's theory. Reality doesn't always agree with my theories. :-)
> remote-curl.c | 30 ++++++++++++++++++++++++++++++ > 1 files changed, 30 insertions(+), 0 deletions(-)
Acked-by: Shawn O. Pearce <spearce@spearce.org>
-- Shawn.