Re: [PATCH/RFC] Allow curl to rewind the RPC read buffer at any time
- From
Daniel Stenberg <daniel@haxx.se>
- Date
- Dec 2, 2009, 09:19 UTC
- Message-ID
- <alpine.DEB.2.00.0912021011430.19179@tvnag.unkk.fr>
- In-Reply-To
- <be6fef0d0912011803u2ec9ab1bsa167cf59de4dd47c@mail.gmail.com>
On Wed, 2 Dec 2009, Tay Ray Chuan wrote:
> According to Martin, Expect: 100-continue is not working due to libcurl.
Right, that is/was a bug in how libcurl behaves when the application itself has set the "Expect: 100-continue" header. Martin has provided a fix for that for the next libcurl version though, but that won't make a lot of existing users happy.
Thinking about this particular problem, what is the motivation for git to forcily add that header in the first place? I mean, libcurl does add the header by itself when it thinks it is necessary and then it handles it correctly.
I'm just suggesting (and speculating widely since I don't know git internals) that a possible way to work around this particular bug may be to reconsider how git adds the Expect header.
It's just an idea. Please ignore it if it is totally crazy.
-- / daniel.haxx.se