git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix safe_create_leading_directories() for Windows

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 2, 2014, 20:42 UTC
Message-ID
<alpine.DEB.1.00.1401022135030.1191@s15462909.onlinehome-server.info>
In-Reply-To
<xmqqtxdmp39a.fsf@gitster.dls.corp.google.com>
Hi Junio,
On Thu, 2 Jan 2014, Junio C Hamano wrote:
Show 17 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Thu, 2 Jan 2014, Sebastian Schuberth wrote:
> >
> >> See https://github.com/msysgit/git/pull/80.
> >
> > Thanks Sebastian!
> >
> > However, since the git.git project is not comfortable with the concept
> > of pull requests (which is why you submitted this patch via mail), I
> > believe that we have to explain the rationale in the commit message.
> > So here goes my attempt:
> 
> Thanks; the conclusion is correct --- you need a good commit message in
> the recorded history.  That does not have anything to do with
> integrating with pulling from subsystem maintainers, which we regularly
> do.

I should have pointed out that I was talking about the concept of pull requests, not the concept of accepting pull requests from dedicated subsystem maintainers.

Show 7 quoted lines
> > On Linux, we can get away with assuming that the directory separator
> > is a forward slash, but that is wrong in general. For that purpose,
> > the is_dir_sep() function was introduced a long time ago. By using it
> > in safe_create_leading_directories(), we proof said function for use
> > on platforms where the directory separator is different from Linux'.
> 
> Perhaps with s|Linux|POSIX|,
No, for two reasons:
* OpenVMS supports POSIX, yes? And OpenVMS does not have the forward slash
  as directory separator but instead the dot, yes?
* it would be dishonest. The reason is not that we looked at the POSIX
  standard when we determined how to implement
  safe_create_leading_directories(), but at Linux.
> but more importantly, was there a specific error scenario that triggered
> this change?

Yes, the concrete use case that triggered the pull request whose change we did not accept but instead would prefer Sebastian's patch is where a user called

	git clone <URL> C:\directory
in cmd.exe.

Ciao, Johannes

Previous: Junio C HamanoNext: Sebastian Schuberth
Message 11 of 22 in “Fix safe_create_leading_directories() for Windows”
  1. Fix safe_create_leading_directories() for WindowsSebastian Schuberth, Jan 2, 2014
  2. Johannes SchindelinJan 2, 2014
  3. Sebastian SchuberthJan 2, 2014
  4. John KeepingJan 2, 2014
  5. Sebastian SchuberthJan 2, 2014
  6. Johannes SchindelinJan 2, 2014
  7. Erik Faye-LundJan 7, 2014
  8. Johannes SchindelinJan 7, 2014
  9. Sebastian SchuberthJan 7, 2014
  10. Junio C HamanoJan 2, 2014
  11. Johannes SchindelinJan 2, 2014
  12. Sebastian SchuberthJan 2, 2014
  13. Fix safe_create_leading_directories() for WindowsSebastian Schuberth, Jan 2, 2014
  14. Johannes SchindelinJan 2, 2014
  15. Junio C HamanoJan 2, 2014
  16. Junio C HamanoJan 2, 2014
  17. Junio C HamanoJan 2, 2014
  18. Junio C HamanoJan 2, 2014
  19. Johannes SchindelinJan 2, 2014
  20. Sebastian SchuberthJan 19, 2014
  21. Sebastian SchuberthJan 19, 2014
  22. Junio C HamanoJan 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.