Re: [PATCH] Fix safe_create_leading_directories() for Windows
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 2, 2014, 17:33 UTC
- Message-ID
- <alpine.DEB.1.00.1401021826120.1191@s15462909.onlinehome-server.info>
- In-Reply-To
- <52C5A039.6030408@gmail.com>
Hi,
On Thu, 2 Jan 2014, Sebastian Schuberth wrote:
> See https://github.com/msysgit/git/pull/80.
Thanks Sebastian!
However, since the git.git project is not comfortable with the concept of pull requests (which is why you submitted this patch via mail), I believe that we have to explain the rationale in the commit message. So here goes my attempt:
-- snip -- On Linux, we can get away with assuming that the directory separator is a forward slash, but that is wrong in general. For that purpose, the is_dir_sep() function was introduced a long time ago. By using it in safe_create_leading_directories(), we proof said function for use on platforms where the directory separator is different from Linux'. -- snap --
Hmm? Dscho