Re: [PATCH] Fix safe_create_leading_directories() for Windows
On 02.01.2014 20:55, Junio C Hamano wrote:
> Thanks; the conclusion is correct --- you need a good commit
> message in the recorded history. That does not have anything to do
> with integrating with pulling from subsystem maintainers, which we
> regularly do.
I'll send a v2 which adds a proper commits message inline.
> Perhaps with s|Linux|POSIX|, but more importantly, was there a
> specific error scenario that triggered this change?
Yes, cloning to a non-existent directory with Windows paths fails like:
fatal: could not create work tree dir 'c:\foo\bar'.: No such file or directory
Seems like the path to clone to is taken as-is from argv in cmd_clone(). So maybe another solution would be to replace all backslashes with forward slashes already there?
--
Sebastian Schuberth
Sebastian Schuberth <sschuberth@gmail.com>