Re: Re: 1.7.10 doesn't show file pushstatus

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 2, 2012, 01:04 UTC
Message-ID: <alpine.DEB.1.00.1205020301560.27828@bonsai2>
In-Reply-To: <20120501084048.GA21904@sigill.intra.peff.net>

Hi Peff,

On Tue, 1 May 2012, Jeff King wrote:

Show 23 quoted lines

> On Tue, May 01, 2012 at 03:33:26AM -0400, Jeff King wrote:
> 
> > In this case, send pack gets its arguments from the command-line, not
> > from the options set at the transport layer. Remote-curl will pass along
> > "--quiet" if we get that from the transport layer, but it does not
> > otherwise pass along the "progress" flag. So there are two problems:
> > 
> >   1. send-pack defaults its progress boolean to 0. Before 01fdc21, that
> >      was OK, because it meant "don't explicitly ask for progress". But
> >      after 01fdc21 that now means "explicitly ask for no progress", and
> >      the direct-transport code paths were updated without updating
> >      cmd_send_pack.
> > 
> >   2. There's no way to tell send-pack explicitly "yes, I would like
> >      progress, no matter what isatty(2) says". I doubt anybody cares
> >      much, but it probably makes sense to handle that for the sake of
> >      completeness.
> 
> The following patch series fixes this:
> 
>   [1/3]: send-pack: show progress when isatty(2)
>   [2/3]: teach send-pack about --[no-]progress
>   [3/3]: t5541: test more combinations of --progress

Thanks. I applied and pushed it after testing on Linux.

David, if you want to relieve me of maintenance burden in the future, you

# apply the patches

# push them to a fork on GitHub

# run the tests

# report back to the mailing list (including the outcome of the test --
  detailed, if it fails)

Ciao, Johannes

-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en