Re: [PATCH 3/3] t5541: test more combinations of --progress

From: Jeff King <peff@peff.net>
Date: May 1, 2012, 09:37 UTC
Message-ID: <20120501093719.GA7538@sigill.intra.peff.net>
In-Reply-To: <20120501093501.GB22633@ecki.lan>

On Tue, May 01, 2012 at 11:35:01AM +0200, Clemens Buchacher wrote:

Show 8 quoted lines

> Can we add this on top or squashed in? I regret using tee when I
> originally wrote the test.
> 
> --8<--
> Subject: [PATCH] t5541: check return codes
> 
> By piping output to tee, the return code of the command is hidden.
> Instead, redirect output to a file directly.

Ugh, absolutely. I blindly followed the existing style without thinking about whether using tee was sane or not. And it's not. Thanks.

-Peff

-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en