Re: [PATCH 3/3] t5541: test more combinations of --progress

From: Junio C Hamano <gitster@pobox.com>
Date: May 1, 2012, 20:53 UTC
Message-ID: <7vehr38vyl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4FA04B4C.4090507@in.waw.pl>

Zbigniew Jędrzejewski-Szmek  <zbyszek@in.waw.pl> writes:

Show 12 quoted lines

>> +test_expect_success 'push --progress shows progress to non-tty' '
>> +	cd "$ROOT_PATH"/test_repo_clone &&
>> +	test_commit progress &&
>> +	git push --progress 2>&1 | tee output &&
>> +	grep "^To http" output &&
>> +	grep "^Writing objects" output
>> +'
>> +
> I understand that test_i18ngrep is not necessary, because pack-objects.c
> is not internationalized. But wouldn't it make sense to use
> test_i18ngrep in preparation, so that tests don't have to be modified
> later on?

In this test, we are not interested in making sure the progress output is properly localized. I'd rather see it keep using grep and if you really care, run "git push" under "LANG=C LC_ALL=C" or something reliable instead.

-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en