git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [msysGit] Re: [PATCHv2] Compile fix for MSVC

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 1, 2011, 18:40 UTC
Message-ID
<alpine.DEB.1.00.1111011332400.32316@s15462909.onlinehome-server.info>
In-Reply-To
<CABPQNSaCRRRpEQPG1Mb4DovkMdQSBhHTm-i7y5M4iT+ndHX4XA@mail.gmail.com>
Hi kusma,
On Tue, 1 Nov 2011, Erik Faye-Lund wrote:
Show 16 quoted lines
> On Tue, Nov 1, 2011 at 1:09 AM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>
> > On Mon, 31 Oct 2011, Junio C Hamano wrote:
> >
> >> Thanks. The patch looks good from a POSIX person's point of view, and 
> >> I do not immediately see how this would break other variants of 
> >> Windows build at least from the code inspection.
> >
> > As my virtual machine still ran the test suite after my latest 
> > rebasing merge when I left work, I could not test the MSVC stuff just 
> > yet. I wanted to do that tomorrow and either merge or come back with 
> > suggestions.
> 
> I've applied the patches to 'devel', verified that the result builds, 
> and pushed it out.

I've applied your patches and made up commit messages. So far, I only tested with MSVCE 9.0 (AKA Express 2008) before running out of time. Please have a look at the commits (since I could build a git.exe with the correct version, I felt comfortable enough to push out to 'devel').

Maybe if someone donates Jenkins resources, we could make an automatic branch in the future that has git.sln in it (similar to the 'html' branch in git.git).

Ciao, Dscho

Previous: Junio C HamanoNext: Erik Faye-Lund
Message 12 of 22 in “[PATCHv2] Compile fix for MSVC”
  1. Vincent van RavesteijnOct 31, 2011
  2. 1/3 Compile fix for MSVC: Do not include sys/resources.hVincent van Ravesteijn, Oct 31, 2011
  3. 2/3 Compile fix for MSVC: Include <io.h>Vincent van Ravesteijn, Oct 31, 2011
  4. 3/3 MSVC: Remove unneeded header stubsVincent van Ravesteijn, Oct 31, 2011
  5. Junio C HamanoOct 31, 2011
  6. Johannes SchindelinNov 1, 2011
  7. Junio C HamanoNov 1, 2011
  8. Erik Faye-LundNov 1, 2011
  9. Junio C HamanoNov 1, 2011
  10. Erik Faye-LundNov 1, 2011
  11. Junio C HamanoNov 1, 2011
  12. Johannes SchindelinNov 1, 2011
  13. Erik Faye-LundNov 1, 2011
  14. Johannes SchindelinNov 1, 2011
  15. Vincent van RavesteijnNov 1, 2011
  16. Johannes SchindelinNov 1, 2011
  17. Vincent van RavesteijnNov 1, 2011
  18. Pat ThoytsNov 2, 2011
  19. Vincent van RavesteijnNov 2, 2011
  20. Sebastian SchuberthNov 4, 2011
  21. Erik Faye-LundNov 1, 2011
  22. Junio C HamanoNov 1, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.