git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [msysGit] Re: [PATCHv2] Compile fix for MSVC

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Nov 1, 2011, 20:35 UTC
Message-ID
<CABPQNSaiFpmHa_GLF8PaejvXTkqCMoWG+Cd4MbNrqXF-SXR1yw@mail.gmail.com>
In-Reply-To
<7vy5vzn65u.fsf@alter.siamese.dyndns.org>
On Tue, Nov 1, 2011 at 5:45 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
> Erik Faye-Lund <kusmabite@gmail.com> writes:
>
>> This is a slip-up in my patch 0f77dea, but I don't quite understand
>> why this didn't cause any troubles until now... I guess the MSVC parts
>> of Makefile are somehow more dependent on LIB_H or something...
>>
>> Junio, is it too late to squash in a fix-up? If it is, I can send a
>> fixup-patch instead...
>
> I can queue this for v1.7.8-rc1 if you want, as it is a fix whether or not
> we define MSVC or not while building.
Yes, please do. This looks good to me, thanks for picking it up :)
Show 7 quoted lines
>> So there's some more work left to be done. Unfortunately, I don't have
>> time to polish these changes for at least a week, so unless someone
>> volunteers it'll take some time...
>
> It seems, from your description, that msvc update series has some way to
> go and it probably is better to be cooked by Windows-savvy folks for
> another cycle.

I don't think you need to hold these three patches; with them I was able to build your 'master'. I believe the problems I bumped into only exist in msysgit's 'devel' (or in your 'next', which msysgit/devel is based upon).

> Which would mean that your upload-archive series is still
> good to go as long as it works for non-MSVC/mingw people, right?
>

Yes. Apart from the slip-up with LIB_H, my upload-archive series should be unrelated to the issues I found here.

Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 22 in “[PATCHv2] Compile fix for MSVC”
  1. Vincent van RavesteijnOct 31, 2011
  2. 1/3 Compile fix for MSVC: Do not include sys/resources.hVincent van Ravesteijn, Oct 31, 2011
  3. 2/3 Compile fix for MSVC: Include <io.h>Vincent van Ravesteijn, Oct 31, 2011
  4. 3/3 MSVC: Remove unneeded header stubsVincent van Ravesteijn, Oct 31, 2011
  5. Junio C HamanoOct 31, 2011
  6. Johannes SchindelinNov 1, 2011
  7. Junio C HamanoNov 1, 2011
  8. Erik Faye-LundNov 1, 2011
  9. Junio C HamanoNov 1, 2011
  10. Erik Faye-LundNov 1, 2011
  11. Junio C HamanoNov 1, 2011
  12. Johannes SchindelinNov 1, 2011
  13. Erik Faye-LundNov 1, 2011
  14. Johannes SchindelinNov 1, 2011
  15. Vincent van RavesteijnNov 1, 2011
  16. Johannes SchindelinNov 1, 2011
  17. Vincent van RavesteijnNov 1, 2011
  18. Pat ThoytsNov 2, 2011
  19. Vincent van RavesteijnNov 2, 2011
  20. Sebastian SchuberthNov 4, 2011
  21. Erik Faye-LundNov 1, 2011
  22. Junio C HamanoNov 1, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.