git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2] Compile fix for MSVC

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Nov 1, 2011, 00:36 UTC
Message-ID
<CABPQNSaW+ciEzAMruYVgK_y2xf=sExYiFfdbS4xonKe=h-APjA@mail.gmail.com>
In-Reply-To
<7vd3dcq4s5.fsf@alter.siamese.dyndns.org>
On Mon, Oct 31, 2011 at 9:34 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> Thanks. The patch looks good from a POSIX person's point of view, and I do
> not immediately see how this would break other variants of Windows build
> at least from the code inspection.
>
> So I'll queue this, but I'll leave it to you and msysgit folks to decide
> if this topic should be merged to 1.7.8-rc1, as I do not have equipment,
> expertise, nor time to judge it myself (other than the code inspection we
> have already done here).
>
> Please give me an Ack or two by the end of this week. Thanks.

The result of applying this on top of the current master (1.7.8-rc0) compiles and seem to runs fine for me, both with the MinGW supplied by msysGit, and MSVC (as outlined by compat/vcbuild/README). Without the patches, it fails to build with MSVC. In addition, the changes looks good to me. So:

Acked-by: Erik Faye-Lund <kusmabite@gmail.com>
Previous: Sebastian SchuberthNext: Junio C Hamano
Message 21 of 22 in “[PATCHv2] Compile fix for MSVC”
  1. Vincent van RavesteijnOct 31, 2011
  2. 1/3 Compile fix for MSVC: Do not include sys/resources.hVincent van Ravesteijn, Oct 31, 2011
  3. 2/3 Compile fix for MSVC: Include <io.h>Vincent van Ravesteijn, Oct 31, 2011
  4. 3/3 MSVC: Remove unneeded header stubsVincent van Ravesteijn, Oct 31, 2011
  5. Junio C HamanoOct 31, 2011
  6. Johannes SchindelinNov 1, 2011
  7. Junio C HamanoNov 1, 2011
  8. Erik Faye-LundNov 1, 2011
  9. Junio C HamanoNov 1, 2011
  10. Erik Faye-LundNov 1, 2011
  11. Junio C HamanoNov 1, 2011
  12. Johannes SchindelinNov 1, 2011
  13. Erik Faye-LundNov 1, 2011
  14. Johannes SchindelinNov 1, 2011
  15. Vincent van RavesteijnNov 1, 2011
  16. Johannes SchindelinNov 1, 2011
  17. Vincent van RavesteijnNov 1, 2011
  18. Pat ThoytsNov 2, 2011
  19. Vincent van RavesteijnNov 2, 2011
  20. Sebastian SchuberthNov 4, 2011
  21. Erik Faye-LundNov 1, 2011
  22. Junio C HamanoNov 1, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.