Re: Re: [PATCH] fix threaded grep for machines with only one cpu
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 18, 2010, 09:10 UTC
- Message-ID
- <alpine.DEB.1.00.1002181009440.20986@pacific.mpi-cbg.de>
- In-Reply-To
- <20100217224330.GB8029@book.hvoigt.net>
Hi,
On Wed, 17 Feb 2010, Heiko Voigt wrote:
Show 16 quoted lines
> On Tue, Feb 16, 2010 at 03:59:43PM -0800, Junio C Hamano wrote: > > -- >8 -- > > Subject: Fix use of mutex in threaded grep > > > > The program can decide at runtime not to use threading even if the support > > is compiled in. In such a case, mutexes are not necessary and left > > uninitialized. But the code incorrectly tried to take and release the > > read_sha1_mutex unconditionally. > > > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > > Acked-by: Fredrik Kuivinen <frekui@gmail.com> > > Just to be sure I just tested this one as well. If you like you can add > a: > > Tested-by: Heiko Voigt <hvoigt@hvoigt.net>
I have pushed the commit (at least the second-last :-) to 4msysgit's devel already (in the vain hope to release a Git for Windows on Tuesday...)
Ciao, Dscho