Re: Re: [PATCH] fix threaded grep for machines with only one cpu

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Feb 17, 2010, 22:43 UTC
Message-ID: <20100217224330.GB8029@book.hvoigt.net>
In-Reply-To: <7viq9wzq8g.fsf@alter.siamese.dyndns.org>

On Tue, Feb 16, 2010 at 03:59:43PM -0800, Junio C Hamano wrote:

Show 10 quoted lines

> -- >8 --
> Subject: Fix use of mutex in threaded grep
> 
> The program can decide at runtime not to use threading even if the support
> is compiled in.  In such a case, mutexes are not necessary and left
> uninitialized.  But the code incorrectly tried to take and release the
> read_sha1_mutex unconditionally.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> Acked-by: Fredrik Kuivinen <frekui@gmail.com>

Just to be sure I just tested this one as well. If you like you can add a:

Tested-by: Heiko Voigt <hvoigt@hvoigt.net>

cheers Heiko