Re: [PATCH] fix threaded grep for machines with only one cpu

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 16, 2010, 01:12 UTC
Message-ID: <7v3a12t24a.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vwryet2cw.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> Heiko Voigt <hvoigt@hvoigt.net> writes:
>
>> In case the machine has only one cpu the initialization was
>> skipped.
>
> An obvious question that forces reviewers to go "Huh?" is why this
> matters.
>
> If use_threads is false, we do not call start_threads(), and I think at
> least the intent of the threaded grep code in 5b594f4 (Threaded grep,
> 2010-01-25) is that uninitialized mutexes matter at all in that case.

s/matter/do not &/; obviously.